Draft
Conversation
…function, which controls the narrowband comms main loop, started working on handle_receive interrupt service routine (isr)
…odule to use a static class instead of static variables
…(todo), isr handler and rxtx task as static member function, removed singleton pattern in facor of anonymus namespace with single class instance
…faster than semaphores)
…s returning size of packed buffer, added check to see if malloc fails
JoelHer
reviewed
Apr 16, 2026
Member
There was a problem hiding this comment.
You might want to set the idf version >6.0.0
Contributor
Author
There was a problem hiding this comment.
oh yeah, that's an artifact because the branch is based on an old version of vigilant engine.
all of this is work in progress btw, just wanted to create a PR to have some overview of my changes
Member
There was a problem hiding this comment.
Yea no worries, i thought that ^^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented narrowband transport layer.
depends on
features
to-do